Re: [PATCH v1] convert: add "status=delayed" to filter process protocol

From: Eric Wong <e@80x24.org>
Date: Jan 8, 2017, 20:45 UTC
Message-ID: <20170108204517.GA13779@starla>
In-Reply-To: <20170108191736.47359-1-larsxschneider@gmail.com>

larsxschneider@gmail.com wrote:

> +++ b/t/t0021/rot13-filter.pl

Show 12 quoted lines

> +$DELAY{'test-delay1.r'} = 1;
> +$DELAY{'test-delay3.r'} = 3;
> 
>  open my $debug, ">>", "rot13-filter.log" or die "cannot open log file: $!";
> 
> @@ -166,6 +176,15 @@ while (1) {
>  		packet_txt_write("status=abort");
>  		packet_flush();
>  	}
> +	elsif ( $command eq "smudge" and
> +		    exists $DELAY{$pathname} and
> +		    $DELAY{$pathname} gt 0 ) {

Use '>' for numeric comparisons.  'gt' is for strings (man perlop)

Sidenote, staying <= 80 columns for the rest of the changes is strongly preferred, some of us need giant fonts. I think what Torsten said about introducing a new *_internal function can also help with that.

Thanks.