git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] rebase--interactive: count squash commits above 10 correctly

From
Jeff King <peff@peff.net>
Date
Jan 7, 2017, 11:05 UTC
Message-ID
<20170107110539.jcx25pdy7cosojcp@sigill.intra.peff.net>
In-Reply-To
<alpine.DEB.2.20.1701071150490.3469@virtualbox>
On Sat, Jan 07, 2017 at 11:51:23AM +0100, Johannes Schindelin wrote:
Show 7 quoted lines
> > We can fix this by making the ".*" less greedy. Instead of
> > depending on ".*?" working portably, we can just limit the
> > match to non-digit characters, which accomplishes the same
> > thing.
> 
> Or we could simply require a space before the first digit, which would
> maybe look a little simpler.

Yeah, if we can assume that all translations will always have a space there. It is almost certainly true for Western languages, but I don't know about others. It looks like the Korean translation omits a space _after_ the digits, but there is still one before.

-Peff
Previous: Johannes SchindelinNext: Junio C Hamano
Message 5 of 6 in “Squashing commits with git rebase -i may miscount commits in commit message”
  1. Brandon TolschJan 6, 2017
  2. Johannes SchindelinJan 6, 2017
  3. rebase--interactive: count squash commits above 10 correctlyJeff King, Jan 7, 2017
  4. Johannes SchindelinJan 7, 2017
  5. Jeff KingJan 7, 2017
  6. Junio C HamanoJan 8, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.