Re: [PATCH 2/2] giteveryday: unbreak rendering with AsciiDoctor
- From
Jeff King <peff@peff.net>
- Date
- Jan 4, 2017, 08:15 UTC
- Message-ID
- <20170104081544.5htofa3zpgkvty7x@sigill.intra.peff.net>
- In-Reply-To
- <c3b21bbec96408c4d6698129fd336c24c9e2f0f0.1483373021.git.johannes.schindelin@gmx.de>
On Mon, Jan 02, 2017 at 05:04:05PM +0100, Johannes Schindelin wrote:
Show 18 quoted lines
> The "giteveryday" document has a callout list that contains a code > block. This is not a problem for AsciiDoc, but AsciiDoctor sadly was > explicitly designed *not* to render this correctly [*1*]. The symptom is > an unhelpful > > line 322: callout list item index: expected 1 got 12 > line 325: no callouts refer to list item 1 > line 325: callout list item index: expected 2 got 13 > line 327: no callouts refer to list item 2 > > In Git for Windows, we rely on the speed improvement of AsciiDoctor (on > this developer's machine, `make -j15 html` takes roughly 30 seconds with > AsciiDoctor, 70 seconds with AsciiDoc), therefore we need a way to > render this correctly. > > The easiest way out is to simplify the callout list, as suggested by > AsciiDoctor's author, even while one may very well disagree with him > that a code block hath no place in a callout list.
This looks like a good re-write to avoid the issue while maintaining the meaning and flow of the original.
-Peff