Re: index-pack outside of repository?
- From
Jeff King <peff@peff.net>
- Date
- Dec 16, 2016, 21:43 UTC
- Message-ID
- <20161216214322.xibllaw2iibhc5nv@sigill.intra.peff.net>
- In-Reply-To
- <xmqq37hnu50y.fsf@gitster.mtv.corp.google.com>
On Fri, Dec 16, 2016 at 10:01:49AM -0800, Junio C Hamano wrote:
Show 15 quoted lines
> >> I think 2/3 is a good change to ensure we get a reasonable error for
> >> "index-pack --stdin", and 3/3 is a very good cleanup. Both of them
> >> of course are enabled by 1/3.
> >>
> >> We still fail "nongit git index-pack tmp.pack" with a BUG: though.
> >
> > Wait.
> >
> > This only happens with a stalled-and-to-be-discarded topic on 'pu'.
> > Please don't waste time digging it (yet).
>
> Don't wait ;-). My mistake. We can see t5300 broken with this
> change and b1ef400eec ("setup_git_env: avoid blind fall-back to
> ".git"", 2016-10-20) without anything else. We still need to
> address it.Ah, I only checked that it did not do anything terrible like write into ".git". But it looks like it still looks at the git_dir value as part of the collision check.
Here's a patch, on top of the rest of the series.
-- >8 -- Subject: [PATCH] index-pack: skip collision check when not in repository
You can run "git index-pack path/to/foo.pack" outside of a repository to generate an index file, or just to verify the contents. There's no point in doing a collision check, since we obviously do not have any objects to collide with.
The current code will blindly look in .git/objects based on the result of setup_git_env(). That effectively gives us the right answer (since we won't find any objects), but it's a waste of time, and it conflicts with our desire to eventually get rid of the "fallback to .git" behavior of setup_git_env().
Signed-off-by: Jeff King <peff@peff.net> --- I didn't do a test, as this doesn't really have any user-visible behavior change. I guess technically if you had a non-repo with ".git/objects/12/3456..." in it we would erroneously read it, but that's kind of bizarre. The interesting test is that when merged with jk/no-looking-at-dotgit-outside-repo-final, the test in t5300 doesn't die.
builtin/index-pack.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/builtin/index-pack.c b/builtin/index-pack.c index d450a6ada2..f4b87c6c9f 100644 --- a/builtin/index-pack.c +++ b/builtin/index-pack.c @@ -787,13 +787,15 @@ static void sha1_object(const void *data, struct object_entry *obj_entry, const unsigned char *sha1) { void *new_data = NULL; - int collision_test_needed; + int collision_test_needed = 0; assert(data || obj_entry); - read_lock(); - collision_test_needed = has_sha1_file_with_flags(sha1, HAS_SHA1_QUICK); - read_unlock(); + if (startup_info->have_repository) { + read_lock(); + collision_test_needed = has_sha1_file_with_flags(sha1, HAS_SHA1_QUICK); + read_unlock(); + } if (collision_test_needed && !data) { read_lock();
-- 2.11.0.348.g960a0b554