Re: Allow "git shortlog" to group by committer information
- From
Jeff King <peff@peff.net>
- Date
- Dec 16, 2016, 13:51 UTC
- Message-ID
- <20161216135141.yhas67pzfm7bxxum@sigill.intra.peff.net>
- In-Reply-To
- <20161216133940.hu474phggdslh6ka@sigill.intra.peff.net>
On Fri, Dec 16, 2016 at 08:39:40AM -0500, Jeff King wrote:
Show 10 quoted lines
> I'm OK with the approach your patch takes, but I think there were some > unresolved issues: > > - are we OK taking the short "-c" for this, or do we want > "--group-by=committer" or something like it? > > - no tests; you can steal the general form from my [1] > > - no documentation (can also be stolen from [1], though the syntax is > quite different)
Being moved by the holiday spirit, I wrote a patch to address the latter two. ;)
It obviously would need updating if we switch away from "-c", but I think I am OK with the short "-c" (even if we add a more exotic grouping option later, this can remain as a short synonym).
-- >8 -- Subject: [PATCH] shortlog: test and document --committer option
This puts the final touches on the feature added by fbfda15fb8 (shortlog: group by committer information, 2016-10-11).
Signed-off-by: Jeff King <peff@peff.net> --- Documentation/git-shortlog.txt | 4 ++++ t/t4201-shortlog.sh | 13 +++++++++++++ 2 files changed, 17 insertions(+)
diff --git a/Documentation/git-shortlog.txt b/Documentation/git-shortlog.txt index 31af7f2736..ee6c5476c1 100644 --- a/Documentation/git-shortlog.txt +++ b/Documentation/git-shortlog.txt @@ -47,6 +47,10 @@ OPTIONS Each pretty-printed commit will be rewrapped before it is shown. +-c:: +--committer:: + Collect and show committer identities instead of authors. + -w[<width>[,<indent1>[,<indent2>]]]:: Linewrap the output by wrapping each line at `width`. The first line of each entry is indented by `indent1` spaces, and the second diff --git a/t/t4201-shortlog.sh b/t/t4201-shortlog.sh index ae08b57712..6c7c637481 100755 --- a/t/t4201-shortlog.sh +++ b/t/t4201-shortlog.sh @@ -190,4 +190,17 @@ test_expect_success 'shortlog with --output=<file>' ' test_line_count = 3 shortlog ' +test_expect_success 'shortlog --committer (internal)' ' + cat >expect <<-\EOF && + 3 C O Mitter + EOF + git shortlog -nsc HEAD >actual && + test_cmp expect actual +' + +test_expect_success 'shortlog --committer (external)' ' + git log --format=full | git shortlog -nsc >actual && + test_cmp expect actual +' + test_done
-- 2.11.0.348.g960a0b554