Re: [PATCH v9 5/5] transport: add from_user parameter to is_transport_allowed
- From
- Brandon Williams <bmwill@google.com>
- Date
- Dec 14, 2016, 21:58 UTC
- Message-ID
- <20161214215832.GF20063@google.com>
- In-Reply-To
- <20161214211229.mpgu3hahlfbdxys6@sigill.intra.peff.net>
On 12/14, Jeff King wrote:
Show 18 quoted lines
> On Wed, Dec 14, 2016 at 03:33:49PM -0500, Jeff King wrote: > > > One other "simple" fix is at the moment we parse http-alternates, to > > parse the URL ourself and check the policy. Like: > > [...] > > I may have convinced myself this is a reasonable approach. > > So here it is in patch form, with a test. > > I also took a look at how bad it would be to plumb through the "this is > an alternate" flag. And it's actually a little nasty, because the > http-walker isn't calling get_active_slot() itself. It's relying on > http_get_file() and other wrappers. The recent http_get_options makes > this slightly less terrible, but I'd still rather avoid infecting the > general http code that is used for the smart-http code paths. > > So I think this patch on top of your series, plus the other minor fixes > we've discussed, the topic should be ready for 'next'.
Sounds good, I'll make those few changes, place this patch ontop of the series and send out v10 of the series in just a bit.
-- Brandon Williams