Re: [RFC/PATCHv2] Makefile: add cppcheck target

From: Jeff King <peff@peff.net>
Date: Dec 14, 2016, 11:24 UTC
Message-ID: <20161214112401.mq3n5kui5eeebdtk@sigill.intra.peff.net>
In-Reply-To: <20161214092731.29076-1-judge.packham@gmail.com>

On Wed, Dec 14, 2016 at 10:27:31PM +1300, Chris Packham wrote:

> Changes in v2:
> - only run over actual git source files.
> - omit any files in t/

I actually wonder if FIND_SOURCE_FILES should be taking care of the "t/" thing. I think "make tags" finds tags in t4051/appended1.c, which is just silly.

> - introduce CPPCHECK_FLAGS which can be overridden in the make command
>   line. This also uses a GNU make-ism to allow CPPCHECK_ADD to specify
>   additional checks to be enabled.

The GNU-ism is fine; we already require GNU make to build.

The patch itself is OK to me, I guess. The interesting part will be whether people start actually _using_ cppcheck and squelching the false positives. I'm not sure how I feel about the in-code annotations. I'd have to see a patch first.

-Peff