Re: [PATCH 0/3] gitk: memory consumption improvements
- From
Paul Mackerras <paulus@ozlabs.org>
- Date
- Dec 12, 2016, 09:51 UTC
- Message-ID
- <20161212095119.GF20934@fergus.ozlabs.ibm.com>
- In-Reply-To
- <de7cd593-0c10-4e93-1681-7e123504f5d5@jump-ing.de>
On Mon, Nov 07, 2016 at 07:54:28PM +0100, Markus Hitter wrote:
Show 14 quoted lines
> > List, Paul, > > after searching for a while on why Gitk sometimes consumes exorbitant amounts of memory I found a pair of minor issues and also a big one: the text widget comes with an unlimited undo manager, which is turned on be default. Considering that each line is inserted seperately, this piles up a huuuge undo stack ... for a read-only text widget. Simply turning off this undo manager saves about 95% of memory when viewing large commits (with tens of thousands of diff lines). > > 3 patches are about to follow: > > - turn off the undo manager, > > - forget already closed file descriptors and > > - forget the 'commitinfo' array on a reload to enforce reloading it. > > I hope this finds you appreciation.
Thanks for the good work in tracking this down and making the patches. I have applied the series. Apologies for slow response (life has been extremely busy for me this year).
Paul.