Re: Git v2.11.0 breaks max depth nested alternates
- From
Jeff King <peff@peff.net>
- Date
- Dec 5, 2016, 07:18 UTC
- Message-ID
- <20161205071822.ndeswelgj5epej5k@sigill.intra.peff.net>
- In-Reply-To
- <49DE271A91214D6DADBD4DE667A1659B@PhilipOakley>
On Sun, Dec 04, 2016 at 11:22:52AM -0000, Philip Oakley wrote:
Show 10 quoted lines
> > Ever since 722ff7f876 (receive-pack: quarantine objects until > > pre-receive accepts, 2016-10-03, v2.11.0), Git has been quarantining > > objects and packs received during an incoming push into a separate > > objects directory and using the alternates mechanism to make them > > available until they are either accepted and moved into the main > > objects directory or rejected and discarded. > > Is there a step here that after the accepted/rejected stage, it should then > decrement the limit back to its original value. The problem description > suggests that might be the case.
No. I thought that at first, too, but this increment happens in the sub-process which is using the extra level of alternates for its entire lifetime. So it "resets" it by exiting, and the parent process never increments its internal value at all.
-Peff