git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Should reset_revision_walk clear more flags?

From
Mike Hommey <mh@glandium.org>
Date
Dec 4, 2016, 23:09 UTC
Message-ID
<20161204230958.h3ilhueqqptv253u@glandium.org>
Hi,

While trying to use the revision walking API twice in a row, I noticed that the second time for the same setup would not yield the same result. In my case, it turns out I was requesting boundaries, and reset_revision_walk() is not resetting CHILD_SHOWN and BOUNDARY, both required to be reset for the second revision walk to work.

So the question is, are consumers supposed to reset those flags on their own, or should reset_revision_walk clear them?

Mike
Next: Mike Hommey
Message 1 of 5 in “Should reset_revision_walk clear more flags?”
  1. Mike HommeyDec 4, 2016
  2. Mike HommeyDec 4, 2016
  3. Jeff KingDec 5, 2016
  4. Junio C HamanoDec 5, 2016
  5. Jeff KingDec 5, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.