Re: [PATCH v4 4/4] submodule_needs_pushing() NEEDSWORK when we can not answer this question

From: Heiko Voigt <hvoigt@hvoigt.net>
Date: Nov 16, 2016, 21:31 UTC
Message-ID: <20161116213100.GA38510@book.hvoigt.net>
In-Reply-To: <xmqqoa1fp72o.fsf@gitster.mtv.corp.google.com>

On Wed, Nov 16, 2016 at 11:18:07AM -0800, Junio C Hamano wrote:

Show 6 quoted lines

> Heiko Voigt <hvoigt@hvoigt.net> writes:
> 
> > Signed-off-by: Heiko Voigt <hvoigt@hvoigt.net>
> > ---
> 
> Needs retitle ;-)  Here is what I tentatively queued.

Thanks ;-) Missed that one.

Show 10 quoted lines

>     submodule_needs_pushing(): explain the behaviour when we cannot answer
>     
>     When we do not have commits that are involved in the update of the
>     superproject in our copy of submodule, we cannot tell if the remote
>     end needs to acquire these commits to be able to check out the
>     superproject tree.  Explain why we answer "no there is no need/point
>     in pushing from our submodule repository" in this case.
>     
>     Signed-off-by: Heiko Voigt <hvoigt@hvoigt.net>
>     Signed-off-by: Junio C Hamano <gitster@pobox.com>

Sound fine to me.

Cheers Heiko