Re: [PATCH 4/5] attr: do not respect symlinks for in-tree .gitattributes

From: Jeff King <peff@peff.net>
Date: Nov 9, 2016, 23:17 UTC
Message-ID: <20161109231720.luuhezzziuhx4r75@sigill.intra.peff.net>
In-Reply-To: <xmqqmvh88dlu.fsf@gitster.mtv.corp.google.com>

On Wed, Nov 09, 2016 at 02:58:37PM -0800, Junio C Hamano wrote:

Show 13 quoted lines

> Duy Nguyen <pclouds@gmail.com> writes:
> 
> > Let's err on the safe side and disable symlinks to outside repo by
> > default (or even all symlinks on .gitattributes and .gitignore as the
> > first step)
> >
> > What I learned from my changes in .gitignore is, if we have not
> > forbidden something, people likely find some creative use for it.
> 
> Yup.  Supporting any symlink in-tree is like requiring Git to be
> used only on symlink-capable filesystems.  Not allowing it sounds
> like a very sensible option and unlike true contents, there is no
> downside to give that limitation to things like .git<anything>.

I'm slightly confused. Did you mean "supporting any in-tree symlink to an out-of-tree destination" in your first sentence?

> Shouldn't we do the same for .gitmodules while we are at it?

Good catch. Though I am inclined to have a flag that just covers all out-of-tree symlinks, regardless of names.

-Peff