Re: send-email garbled header with trailing doublequote in email

From: Andrea Arcangeli <aarcange@redhat.com>
Date: Nov 4, 2016, 00:03 UTC
Message-ID: <20161104000351.GP4611@redhat.com>
In-Reply-To: <20161103141848.42pg6iow24prign5@sigill.intra.peff.net>

On Thu, Nov 03, 2016 at 10:18:48AM -0400, Jeff King wrote:

> bogus header. The munging that postfix does makes things worse, but I

I agree it makes things worse.

> can see why it is confused and does what it does (the whole email is
> inside a double-quoted portion that is never closed, so it probably
> thinks there is no hostname portion at all).

I would see it too, if it actually sent the email to the garbled email address it generated, but it actually got the right email address (because it sent the email to the right address), but it decided to show a different email address in the mail header than the one it sent the email to. But I figure this is the wrong list for such questions :).

> I think if any change were to be made, it would be to recognize this
> bogosity and either clean it up or abort. That ideally would happen via

If postfix continues to do what it does, a strict checking would be my preference of course, assuming it won't break anything that currently works...

If not it's fine too, as nothing particularly "unexpected" happened in git.

At this point double checking that what postfix does is legit is perhaps more worthwhile than adding strictness to git.

Thanks, Andrea