Re: %C(auto) not working as expected

From: Jeff King <peff@peff.net>
Date: Oct 25, 2016, 12:58 UTC
Message-ID: <20161025125856.p2paxt7erl2szptv@sigill.intra.peff.net>
In-Reply-To: <CACsJy8B_AQxm1=vF8i4FPtinq0id1QZPrqp9vvAmAgUns_kgGg@mail.gmail.com>

On Tue, Oct 25, 2016 at 07:52:21PM +0700, Duy Nguyen wrote:

Show 13 quoted lines

> > Yeah, adding a "%C(enable-auto-color)" or something would be backwards
> > compatible and less painful than using "%C(auto)" everywhere. I do
> > wonder if anybody actually _wants_ the "always show color, even if
> > --no-color" behavior. I'm having trouble thinking of a good use for it.
> >
> > IOW, I'm wondering if anyone would disagree that the current behavior is
> > simply buggy.
> 
> Silence in two weeks. I vote (*) making %(<color-name>) honor --color
> and turning the %(auto, no-op, for both log family and for-each-ref.
> We could keep old behavior behind some environment variable if it's
> not much work so it keeps working while people come here and tell us
> about their use cases.

Yeah, sorry. I was blocked on making %(color:) in ref-filter work, which required a bunch of refactoring in ref-filter, which conflicted heavily with the kn/ref-filter-branch-list (which wants to do a lot of the same things), and then I got blocked on reviewing that series (which overall looks pretty sane, but I wanted to really dig in because I think it hasn't gotten very careful review, or at least not recently).

So I'm still hoping to shave that yak at some point. Maybe this week.

-Peff