git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] tag: send fully qualified refnames to verify_tag_and_format

From
Jeff King <peff@peff.net>
Date
Oct 20, 2016, 21:39 UTC
Message-ID
<20161020213904.vfvqqvtow4hycdmx@sigill.intra.peff.net>
In-Reply-To
<20161020165700.qwgli5mbya3d7nzz@LykOS.localdomain>
On Thu, Oct 20, 2016 at 12:57:01PM -0400, Santiago Torres wrote:
Show 13 quoted lines
> > I think you'd really just squash the various bits of this into your
> > series at the right spots, though I don't mind it on top, either.
> > 
> > The big question is to what degree we should care about the verify-tag
> > case. I don't think it's any worse off with this change than it is with
> > your series (its "kind" becomes "OTHER", but I don't think that is
> > actually used for display at all; the name remains the same). I'd be OK
> > with leaving it like this, as a known bug, until get_sha1_with_context()
> > learns to tell us about the ref. It's an unhandled corner case in a
> > brand-new feature, not a regression in an existing one.
> 
> I see now, I think I can sprinkle some of these changes on 2/7 then. The
> rest should be doing 4/7 and 5/7. Does this sound ok?
Yep, that sounds about right.
-Peff
Previous: Santiago Torres
Message 7 of 7 in “Re: [PATCH v4 2/7] ref-filter: add function to print single ref_array_item”
  1. Jeff KingOct 19, 2016
  2. 1/2 ref-filter: split ref_kind_from_filterJeff King, Oct 19, 2016
  3. Junio C HamanoOct 19, 2016
  4. Jeff KingOct 19, 2016
  5. 2/2 tag: send fully qualified refnames to verify_tag_and_formatJeff King, Oct 19, 2016
  6. Santiago TorresOct 20, 2016
  7. Jeff KingOct 20, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.