Re: Drastic jump in the time required for the test suite

From: Jeff King <peff@peff.net>
Date: Oct 20, 2016, 21:03 UTC
Message-ID: <20161020210301.fwuskzylrj6u23ja@sigill.intra.peff.net>
In-Reply-To: <530a3bca-e251-cb43-fb6a-e99c1e64a0a7@kdbg.org>

On Thu, Oct 20, 2016 at 10:38:23PM +0200, Johannes Sixt wrote:

Show 11 quoted lines

> Am 20.10.2016 um 14:31 schrieb Jeff King:
> > Close to 1/3 of those processes are just invoking the bin-wrapper
> > script to set up the EXEC_PATH, etc. I imagine it would not be too hard
> > to just do that in the test script. In fact, it looks like:
> > 
> >   make prefix=/wherever install
> >   GIT_TEST_INSTALLED=/wherever/bin make test
> > 
> > might give you an immediate speedup by skipping bin-wrappers entirely.
> 
> Running the tests with --with-dashes should give you the same effect, no?

Yeah, looks like it. it still uses bin-wrappers for t/helper, but that should be a minority of calls.

Which I think explains why I saw some test failures with the GIT_TEST_INSTALLED above. It does not know about t/helper, but relies on those programs being present in $GIT_BUILD_DIR. So I suspect it has been totally broken since e6e7530d10 (test helpers: move test-* to t/helper/ subdirectory, 2016-04-13).

-Peff