Re: [PATCH 0/4] diff.wsErrorHighlight configuration variable
- From
Jeff King <peff@peff.net>
- Date
- Oct 18, 2016, 11:01 UTC
- Message-ID
- <20161018110132.ehomp2rolb5q2npl@sigill.intra.peff.net>
- In-Reply-To
- <20161004225449.6759-1-gitster@pobox.com>
On Tue, Oct 04, 2016 at 03:54:45PM -0700, Junio C Hamano wrote:
Show 14 quoted lines
> "git diff" and its family of commands have "--ws-error-highlight" > option to allow whitespace breakages on old and context lines > painted in color.diff.whitespace color, instead of the usual "we > paint breakages only on new lines", but there wasn't a configuration > variable that corresponds to it. > > This would be a lot closer to a series that could be acceptable, > compared to the previous "it should look like this" patch. > > Junio C Hamano (4): > t4015: split out the "setup" part of ws-error-highlight test > diff.c: refactor parse_ws_error_highlight() > diff.c: move ws-error-highlight parsing helpers up > diff: introduce diff.wsErrorHighlight option
This topic got stuck in my dreaded "to review" pile and I forgot about it. I see you've already marked it for merging to master, but FWIW, I read it over and did not see any problems.
-Peff