git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/4] diff.wsErrorHighlight configuration variable

From
Jeff King <peff@peff.net>
Date
Oct 18, 2016, 11:01 UTC
Message-ID
<20161018110132.ehomp2rolb5q2npl@sigill.intra.peff.net>
In-Reply-To
<20161004225449.6759-1-gitster@pobox.com>
On Tue, Oct 04, 2016 at 03:54:45PM -0700, Junio C Hamano wrote:
Show 14 quoted lines
> "git diff" and its family of commands have "--ws-error-highlight"
> option to allow whitespace breakages on old and context lines
> painted in color.diff.whitespace color, instead of the usual "we
> paint breakages only on new lines", but there wasn't a configuration
> variable that corresponds to it.
> 
> This would be a lot closer to a series that could be acceptable,
> compared to the previous "it should look like this" patch.
> 
> Junio C Hamano (4):
>   t4015: split out the "setup" part of ws-error-highlight test
>   diff.c: refactor parse_ws_error_highlight()
>   diff.c: move ws-error-highlight parsing helpers up
>   diff: introduce diff.wsErrorHighlight option

This topic got stuck in my dreaded "to review" pile and I forgot about it. I see you've already marked it for merging to master, but FWIW, I read it over and did not see any problems.

-Peff
Previous: Junio C Hamano
Message 11 of 11 in “color.diff.whitespace unused on removed lines”
  1. Sandro SantilliOct 4, 2016
  2. Jeff KingOct 4, 2016
  3. Sandro SantilliOct 4, 2016
  4. Jeff KingOct 4, 2016
  5. Junio C HamanoOct 4, 2016
  6. 0/4 diff.wsErrorHighlight configuration variableJunio C Hamano, Oct 4, 2016
  7. 1/4 t4015: split out the "setup" part of ws-error-highlight testJunio C Hamano, Oct 4, 2016
  8. 2/4 diff.c: refactor parse_ws_error_highlight()Junio C Hamano, Oct 4, 2016
  9. 4/4 diff: introduce diff.wsErrorHighlight optionJunio C Hamano, Oct 4, 2016
  10. 3/4 diff.c: move ws-error-highlight parsing helpers upJunio C Hamano, Oct 4, 2016
  11. Jeff KingOct 18, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.