Re: [PATCH] cocci: avoid self-references in object_id transformations
- From
brian m. carlson <sandals@crustytoothpaste.net>
- Date
- Oct 15, 2016, 13:45 UTC
- Message-ID
- <20161015134503.u3aznujploqee2le@vauxhall.crustytoothpaste.net>
- In-Reply-To
- <a5ed26c0-7fea-259c-74c1-0cd870a35290@web.de>
On Sat, Oct 15, 2016 at 10:25:34AM +0200, René Scharfe wrote:
Show 6 quoted lines
> The object_id functions oid_to_hex, oid_to_hex_r, oidclr, oidcmp, and > oidcpy are defined as wrappers of their legacy counterparts sha1_to_hex, > sha1_to_hex_r, hashclr, hashcmp, and hashcpy, respectively. Make sure > that the Coccinelle transformations for converting legacy function calls > are not applied to these wrappers themselves, which would result in > tautological declarations.
Ah, yes, this is a good idea. I've had to hack around this, but this is much better than having to fix it up by hand.
-- brian m. carlson / brian with sandals: Houston, Texas, US +1 832 623 2791 | https://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: https://keybase.io/bk2204