git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/3] abbrev: auto size the default abbreviation

From
Jeff King <peff@peff.net>
Date
Oct 4, 2016, 12:18 UTC
Message-ID
<20161004121816.yjvxymv46cgmnf5p@sigill.intra.peff.net>
In-Reply-To
<xmqqbmz051yp.fsf@gitster.mtv.corp.google.com>
On Mon, Oct 03, 2016 at 06:37:18PM -0700, Junio C Hamano wrote:
Show 20 quoted lines
> Jeff King <peff@peff.net> writes:
> 
> >> OK, as Linus's "count at the point of use" is already in 'next',
> >> could you make it incremental with a log message?
> >
> > Sure. I wasn't sure if you actually liked my direction or not, so I was
> > mostly just showing off what the completed one would look like.
> 
> To be quite honest, I am not just unsure if I liked your direction;
> rather I am not sure if I actually understood what you perceived as
> a difference that matters between the two approaches.  I wanted to
> hear you explain the difference in terms of "Linus's does this, but
> it is bad in X and Y way, so let's avoid it and do it like Z
> instead".  One effective way to extract that out of you was to force
> you to justify the "incremental" update.
> 
> And it seems that I succeeded ;-).
> 
> I am still not sure if I 100% agree with your first paragraph, but
> at least now I think I see where you are coming from.

For the record, I am OK with Linus's patch as-is. It's mostly "that's not how I would have done it, and the flow seems confusing to me". But that's subjective; I don't think there are any functional flaws in it.

> You probably will hear from Ramsay about extern-ness of msb().
Heh. I seem to have a real problem with that lately.
-Peff
Previous: Junio C HamanoNext: Junio C Hamano
Message 11 of 13 in “auto-sizing default abbreviation length”
  1. 0/3 auto-sizing default abbreviation lengthJunio C Hamano, Oct 1, 2016
  2. 1/3 abbrev: add FALLBACK_DEFAULT_ABBREV to prepare for auto sizingJunio C Hamano, Oct 1, 2016
  3. 2/3 abbrev: prepare for new world orderJunio C Hamano, Oct 1, 2016
  4. 3/3 abbrev: auto size the default abbreviationJunio C Hamano, Oct 1, 2016
  5. Jeff KingOct 3, 2016
  6. Linus TorvaldsOct 3, 2016
  7. Jeff KingOct 3, 2016
  8. Junio C HamanoOct 3, 2016
  9. Jeff KingOct 3, 2016
  10. Junio C HamanoOct 4, 2016
  11. Jeff KingOct 4, 2016
  12. Junio C HamanoNov 2, 2016
  13. Jeff KingNov 2, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.