Re: [PATCH] tmp-objdir: mark some file local symbols static

From: Jeff King <peff@peff.net>
Date: Oct 2, 2016, 12:13 UTC
Message-ID: <20161002121311.4febd7jtc4yv5fev@sigill.intra.peff.net>
In-Reply-To: <f5560f8b-75be-faa0-ce1c-5e2716ee82a5@ramsayjones.plus.com>

On Sun, Oct 02, 2016 at 12:07:27AM +0100, Ramsay Jones wrote:

> If you need to re-roll your 'jk/quarantine-received-objects' branch,
> could you please squash this into the relevant patches.

Oops, thanks. Don't know how I missed both of these.

> [I also note that tmp_objdir_destroy(), declared to be part of the
> public interface, is not currently called from outside tmp_objdir.c.
> Despite being unlikely, it is at least plausible that this function
> may be useful in future. ;-) ]

Yeah, builtin/receive-pack is happy to just rely on process death to destroy it, but I think it's good to keep open an option for somebody to do:

  if (error) {
	tmp_objdir_destroy(t);
	return -1;
  }

or similar.

-Peff