git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 8/9] worktree: honor configuration variables

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 29, 2016, 21:00 UTC
Message-ID
<20160929210014.3874-9-gitster@pobox.com>
In-Reply-To
<20160929210014.3874-1-gitster@pobox.com>

The command accesses default_abbrev (defined in environment.c and is updated via core.abbrev configuration), but never makes any call to git_config(). The output from "worktree list" ignores the abbrev setting for this reason.

Make a call to git_config() to read the default set of configuration variables at the beginning of the command.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 builtin/worktree.c | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/builtin/worktree.c b/builtin/worktree.c
index 6dcf7bd9d270..5c4854d3e4a6 100644
--- a/builtin/worktree.c
+++ b/builtin/worktree.c
@@ -528,6 +528,8 @@ int cmd_worktree(int ac, const char **av, const char *prefix)
 		OPT_END()
 	};
 
+	git_config(git_default_config, NULL);
+
 	if (ac < 2)
 		usage_with_options(worktree_usage, options);
 	if (!prefix)
-- 
2.10.0-589-g5adf4e1
Previous: Junio C HamanoNext: Junio C Hamano
Message 9 of 10 in “allow customizing /etc/gitconfig location with an environment”
  1. 0/9 allow customizing /etc/gitconfig location with an environmentJunio C Hamano, Sep 29, 2016
  2. 1/9 config: allow customizing /etc/gitconfig location with an environmentJunio C Hamano, Sep 29, 2016
  3. 2/9 t1300: always compare expect to actualJunio C Hamano, Sep 29, 2016
  4. 3/9 t1308: ignore system-wide config in the iteration testJunio C Hamano, Sep 29, 2016
  5. 4/9 t1300: check also system-wide configuration file in --show-origin testsJunio C Hamano, Sep 29, 2016
  6. 5/9 t1300: disable system-wide config for tests that wants to read from -cJunio C Hamano, Sep 29, 2016
  7. 6/9 t1300: take contents of system-wide configuration into account in "--list" testJunio C Hamano, Sep 29, 2016
  8. 7/9 t1300: be explicit in local configuration testsJunio C Hamano, Sep 29, 2016
  9. 8/9 worktree: honor configuration variablesJunio C Hamano, Sep 29, 2016
  10. 9/9 core.abbrev: raise the default abbreviation to 12 hexdigitsJunio C Hamano, Sep 29, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.