Re: [PATCH 1/3] tree-walk: be more specific about corrupt tree errors

From: Jeff King <peff@peff.net>
Date: Sep 27, 2016, 04:53 UTC
Message-ID: <20160927045358.wledqitv4qaqmacl@sigill.intra.peff.net>
In-Reply-To: <xmqqtwd2ng8k.fsf@gitster.mtv.corp.google.com>

On Mon, Sep 26, 2016 at 09:01:15PM -0700, Junio C Hamano wrote:

Show 14 quoted lines

> >  5 files changed, 21 insertions(+), 7 deletions(-)
> >  create mode 100644 t/t1007/.gitattributes
> >  create mode 100644 t/t1007/tree-with-empty-filename
> >  create mode 100644 t/t1007/tree-with-malformed-mode
> 
> I hate to report this, but this alone, or together with 2/2, when
> merged to 'pu', I cannot get them to pass the tests in my automated
> integration tests, even though they seem to pass when the problematic
> tests are run manually.  I do not see offhand anything suspicious
> (like something that may be racy) in these two patches but I haven't
> figured out where it goes wrong.
> 
> If somebody manages to find breakages in today's 'pu', please (1) do
> not be too alarmed, and (2) help figure out where things are broken.

I think the problem is just that they refer to t/t1450 (and t1007) from the trash directory as "../t1450". That breaks when the test is run with "--root" (and I imagine that like me, you have --root as part of your automated tests but do not bother with it when doing a one-off run).

-Peff