git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 0/3] handle multiline in-body headers

From
Jeff King <peff@peff.net>
Date
Sep 20, 2016, 23:06 UTC
Message-ID
<20160920230616.n2jwhavi2dzgflno@sigill.intra.peff.net>
In-Reply-To
<cover.1474391594.git.jonathantanmy@google.com>
On Tue, Sep 20, 2016 at 10:17:50AM -0700, Jonathan Tan wrote:
Show 5 quoted lines
> Changes since v2:
> o Removed utf8 translation before scissors line check in
>   check_inbody_header (I was thinking of support for encodings like
>   UTF-16, but I guess those don't work with the current reencode_string
>   anyway since it uses strlen internally)

Yeah, I'd be surprised if UTF-16 works very well with our code in general. If we want to address that, though, the sanest thing is probably to convert it internally to UTF-8 when we remove the transfer encoding in handle_body().

-Peff
Previous: Jonathan TanNext: Junio C Hamano
Message 11 of 12 in “handle multiline in-body headers”
  1. 0/4 handle multiline in-body headersJonathan Tan, Sep 19, 2016
  2. 1/4 mailinfo: separate in-body header processingJonathan Tan, Sep 19, 2016
  3. 3/4 mailinfo: make is_scissors_line take plain char *Jonathan Tan, Sep 19, 2016
  4. 2/4 mailinfo: refactor to support utf8 decode attemptsJonathan Tan, Sep 19, 2016
  5. 4/4 mailinfo: handle in-body header continuationsJonathan Tan, Sep 19, 2016
  6. Junio C HamanoSep 19, 2016
  7. 0/3 handle multiline in-body headersJonathan Tan, Sep 20, 2016
  8. 1/3 mailinfo: separate in-body header processingJonathan Tan, Sep 20, 2016
  9. 2/3 mailinfo: make is_scissors_line take plain char *Jonathan Tan, Sep 20, 2016
  10. 3/3 mailinfo: handle in-body header continuationsJonathan Tan, Sep 20, 2016
  11. Jeff KingSep 20, 2016
  12. Junio C HamanoSep 21, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.