git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[RFC 0/3] http: avoid repeatedly adding curl easy to curlm

From
EWEric Wong <e@80x24.org>
Date
Sep 13, 2016, 00:25 UTC
Message-ID
<20160913002557.10671-1-e@80x24.org>
In-Reply-To
<20160909221942.GS9830@onerussian.com>
(I have some hours online today, so I decided to work on this)

The key patch here is 3/3 which seems like an obvious fix to adding the problem of adding a curl easy handle to a curl multi handle repeatedly.

What is unclear to me is how only Yaroslav's repository seems to trigger this bug after all these years...

However, I am fairly sure this fixes the bug Yaroslav encountered. This patch series is also needed for 2.9.3 and perhaps older maintenance tracks for distros.

In PATCH 2/3, I originally had error checking, but removed it after noticing it was causing failures on wheezy.

I will investigate those failures in a week or two when I regain regular computer access.

These patches are needed for 2.9.x (and probably earlier), too.
The following changes since commit cda1bbd474805e653dda8a71d4ea3790e2a66cbb:
  Sync with maint (2016-09-08 22:00:53 -0700)
are available in the git repository at:
  git://bogomips.org/git-svn.git dumb-http-release
for you to fetch changes up to 3f561d0f0f78fd841708b5e81122e9d825919fd3:
  http: always remove curl easy from curlm session on release (2016-09-12 23:59:35 +0000)
----------------------------------------------------------------
Eric Wong (3):
  http: warn on curl_multi_add_handle failures
  http: consolidate #ifdefs for curl_multi_remove_handle
  http: always remove curl easy from curlm session on release
 http.c | 29 ++++++++++++++++++-----------
 1 file changed, 18 insertions(+), 11 deletions(-)
-- 
EW
Previous: Eric WongNext: Eric Wong
Message 3 of 15 in “git clone http:// fails some times with "Request for d53.. aborted"”
  1. Yaroslav HalchenkoSep 9, 2016
  2. Eric WongSep 10, 2016
  3. 0/3 http: avoid repeatedly adding curl easy to curlmEric Wong, Sep 13, 2016
  4. 1/3 http: warn on curl_multi_add_handle failuresEric Wong, Sep 13, 2016
  5. 2/3 http: consolidate #ifdefs for curl_multi_remove_handleEric Wong, Sep 13, 2016
  6. 3/3 http: always remove curl easy from curlm session on releaseEric Wong, Sep 13, 2016
  7. Junio C HamanoSep 13, 2016
  8. 4/3 http: check curl_multi_remove_handle error codeEric Wong, Sep 21, 2016
  9. Jeff KingSep 21, 2016
  10. Eric WongSep 21, 2016
  11. Jeff KingSep 21, 2016
  12. Yaroslav HalchenkoSep 14, 2016
  13. git submodule add spits unrelated to actual problem error msg about .gitignoreYaroslav Halchenko, Sep 14, 2016
  14. Stefan BellerSep 14, 2016
  15. Yaroslav HalchenkoSep 14, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.