Re: [PATCH] stash: allow ref of a stash by index

From: Jeff King <peff@peff.net>
Date: Sep 5, 2016, 23:52 UTC
Message-ID: <20160905235207.jkxmnrwoc6lllomk@sigill.intra.peff.net>
In-Reply-To: <CAFaJEqu-JUcwLjrQBk_huSa3DZfCf8O4eAZ=UgcXHzN=CLgtpw@mail.gmail.com>

On Mon, Sep 05, 2016 at 11:46:34PM +0200, Øystein Walle wrote:

Show 7 quoted lines

> The bash-specific code is a no-go, so here's a way to do it in a way
> that I think is in line with Git's code style for shell scripts. I took
> the liberty of removing the '|| exit 1' since the rev is verified later
> on anyway, as can be seen in the last piece of context. That way the
> argument munging can be done at a later stage where we don't have to
> loop over multiple ones. The first rev-parse's purpose is just to apply
> --sq.

I wondered how that would impact the error message when there is no such stash. It looks like rev-parse will still return the bogus name on stdout, so we do not run afoul of the "No stash found" code path. We do get:

  $ git.compile stash show foobar
  foobar is not a valid reference

instead of:

  $ git stash show foobar
  fatal: ambiguous argument 'foobar': unknown revision or path not in
  the working tree.
  Use '--' to separate paths from revisions, like this:
  'git <command> [<revision>...] -- [<file>...]'

But I do not see that as a big downside (I might even call it an improvement).

-Peff