[PATCHv2] push: change submodule default to check

From: Stefan Beller <sbeller@google.com>
Date: Aug 24, 2016, 17:30 UTC
Message-ID: <20160824173017.24782-1-sbeller@google.com>

When working with submodules, it is easy to forget to push the submodules. The setting 'check', which checks if any existing submodule is present on at least one remote of the submodule remotes, is designed to prevent this mistake.

Flipping the default to check for submodules is safer than the current default of ignoring submodules while pushing.

Signed-off-by: Stefan Beller <sbeller@google.com>
---

Slightly reworded commit message than in v1, (https://public-inbox.org/git/20160817204848.8983-1-sbeller@google.com/) The patch itself is however the same.

I just push it out now with a new commit message, such that we can easier pick it up later for Git 3.0, when changes that change default make more sense.

As said in an earlier message, you could however also argue that this is fixing a bug in your workflow, so it might be worth fixing before 3.0 as well. I dunno.

Thanks, Stefan

 builtin/push.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/builtin/push.c b/builtin/push.c
index 3bb9d6b..479150a 100644
--- a/builtin/push.c
+++ b/builtin/push.c
@@ -22,7 +22,7 @@ static int deleterefs;
 static const char *receivepack;
 static int verbosity;
 static int progress = -1;
-static int recurse_submodules = RECURSE_SUBMODULES_DEFAULT;
+static int recurse_submodules = RECURSE_SUBMODULES_CHECK;
 static enum transport_family family;
 
 static struct push_cas_option cas;

-- 
2.10.0.rc1.1.g1ceb01a