Re: Extending "extended SHA1" syntax to traverse through gitlinks?

From: Josh Triplett <josh@joshtriplett.org>
Date: Aug 24, 2016, 14:20 UTC
Message-ID: <20160824142024.xnaehfo2spw26apj@x>
In-Reply-To: <b264e17a-12ff-69ca-f130-78d2635a0f85@gmail.com>

On Wed, Aug 24, 2016 at 03:16:56PM +0200, Jakub Narębski wrote:

Show 37 quoted lines

> W dniu 24.08.2016 o 07:36, Junio C Hamano pisze:
> > Jakub Narębski <jnareb@gmail.com> writes:
> > 
> >> The point is that submodule has it's own object database.  It might
> >> be the same as superproject's, but you need to handle submodule objects
> >> being in separate submodule repository anyway.  Common repository is
> >> just a special case.
> >>
> >> By the way, this also means that proposed "extended extended SHA1"
> >> syntax would be useful to user's of submodules...
> > 
> > Not really.
> > 
> > I think that you gave a prime example why <treeish>:<path1>//<path2>
> > is not a useful thing for submodules.  When the syntax resolves to a
> > 40-hex object name, that object name by itself is not useful.
> > 
> > You also need to carry an additional piece of information that lets
> > you identify the location of the repository, in which the object
> > name is valid, in the current user's context (i.e. somewhere in the
> > superproject where the submodule lives).  In other words, you'd need
> > to carry <treeish>:<path1> around anyway for the object name to be
> > useful, so there is no good reason why anybody should insist that
> > the plumbing level resolve <treeish>:<path1>//<path2> directly to an
> > object name in the first place.
> 
> Not really.
> 
> The above means only that the support for new syntax would be not
> as easy as adding it to 'git rev-parse' (and it's built-in equivalent),
> except for the case where submodule uses the same object database as
> supermodule.
> 
> So it wouldn't be as easy (on conceptual level) as adding support
> for ':/<text>' or '<commit>^{/<text>}'.  It would be at least as
> hard, if not harder, as adding support for '@{-1}' and its '-'
> shortcut.

Depends on which cases you want to handle. In the most general case, you'd need to find and process the applicable .gitmodules file, which would only work if you started from the top-level tree, not a random treeish. On the other hand, in the most general case, you don't necessarily even have the module you need, because .git/modules only contains the modules the *current* version needed, not every past version.

As an alternate approach (pun intended): treat every module in .git/modules as an alternate and just look up the object by hash. Or, teach git-submodule to store all the objects for submodules in the supermodule's .git/objects (and teach git's reachability algorithm to respect refs in .git/modules, or store their refs in .git/refs/submodules/ or in a namespace).

> Josh, what was the reason behind proposing this feature? Was it
> conceived as adding completeness to gitrevisions syntax, a low-hanging
> fruit?  It isn't (the latter).  Or was it some problem with submodule
> handling that you would want to use this syntax for?

This wasn't an abstract/theoretical completeness issue. I specifically wanted this syntax for practical use with actual trees containing gitlinks, motivated by having a tool that creates and uses such gitlinks. :)

Show 12 quoted lines

> As for usefulness: this fills the hole in accessing submodules, one
> that could be handled by combining plumbing-level commands.  Namely,
> there are 5 states of submodule (as I understand it)
> 
>  * recorded in ref / commit in supermodule
>  * recorded in the index in supermodule
>  - recorded in ref / commit in submodule
>  - recorded in the index in submodule
>  - state of worktree in submodule
> 
> The last three can be easyly acessed by cd-ing to submodule.  The first
> two are not easy to get, AFAIUC.

Right. I primarily care about those first two cases, especially the first one: given a commit containing a gitlink, how can I easily dig into the linked commit?