git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v12 02/13] apply: rename and move opt constants to apply.h

From
Christian Couder <christian.couder@gmail.com>
Date
Aug 11, 2016, 18:44 UTC
Message-ID
<20160811184501.384-3-chriscool@tuxfamily.org>
In-Reply-To
<20160811184501.384-1-chriscool@tuxfamily.org>

The constants for the "inaccurate-eof" and the "recount" options will be used in both "apply.c" and "builtin/apply.c", so they need to go into "apply.h", and therefore they need a name that is more specific to the API they belong to.

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
 apply.h         |  3 +++
 builtin/apply.c | 11 ++++-------
 2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/apply.h b/apply.h
index 53f09b5..ca1dcee 100644
--- a/apply.h
+++ b/apply.h
@@ -108,4 +108,7 @@ extern int init_apply_state(struct apply_state *state,
 extern void clear_apply_state(struct apply_state *state);
 extern int check_apply_state(struct apply_state *state, int force_apply);
 
+#define APPLY_OPT_INACCURATE_EOF	(1<<0)
+#define APPLY_OPT_RECOUNT		(1<<1)
+
 #endif
diff --git a/builtin/apply.c b/builtin/apply.c
index 429fe44..9c396bb 100644
--- a/builtin/apply.c
+++ b/builtin/apply.c
@@ -4463,9 +4463,6 @@ static int write_out_results(struct apply_state *state, struct patch *list)
 
 static struct lock_file lock_file;
 
-#define INACCURATE_EOF	(1<<0)
-#define RECOUNT		(1<<1)
-
 /*
  * Try to apply a patch.
  *
@@ -4495,8 +4492,8 @@ static int apply_patch(struct apply_state *state,
 		int nr;
 
 		patch = xcalloc(1, sizeof(*patch));
-		patch->inaccurate_eof = !!(options & INACCURATE_EOF);
-		patch->recount =  !!(options & RECOUNT);
+		patch->inaccurate_eof = !!(options & APPLY_OPT_INACCURATE_EOF);
+		patch->recount =  !!(options & APPLY_OPT_RECOUNT);
 		nr = parse_chunk(state, buf.buf + offset, buf.len - offset, patch);
 		if (nr < 0) {
 			free_patch(patch);
@@ -4811,10 +4808,10 @@ int cmd_apply(int argc, const char **argv, const char *prefix)
 		OPT__VERBOSE(&state.apply_verbosely, N_("be verbose")),
 		OPT_BIT(0, "inaccurate-eof", &options,
 			N_("tolerate incorrectly detected missing new-line at the end of file"),
-			INACCURATE_EOF),
+			APPLY_OPT_INACCURATE_EOF),
 		OPT_BIT(0, "recount", &options,
 			N_("do not trust the line counts in the hunk headers"),
-			RECOUNT),
+			APPLY_OPT_RECOUNT),
 		{ OPTION_CALLBACK, 0, "directory", &state, N_("root"),
 			N_("prepend <root> to all filenames"),
 			0, apply_option_parse_directory },
-- 
2.9.2.769.gc0f0333
Previous: Christian CouderNext: Christian Couder
Message 3 of 15 in “libify apply and use lib in am, part 3”
  1. 00/13 libify apply and use lib in am, part 3Christian Couder, Aug 11, 2016
  2. 01/13 builtin/apply: rename option parsing functionsChristian Couder, Aug 11, 2016
  3. 02/13 apply: rename and move opt constants to apply.hChristian Couder, Aug 11, 2016
  4. 04/13 apply: make some parsing functions static againChristian Couder, Aug 11, 2016
  5. 06/13 apply: make it possible to silently applyChristian Couder, Aug 11, 2016
  6. 05/13 apply: use error_errno() where possibleChristian Couder, Aug 11, 2016
  7. 07/13 apply: don't print on stdout in verbosity_silent modeChristian Couder, Aug 11, 2016
  8. 09/13 usage: add get_error_routine() and get_warn_routine()Christian Couder, Aug 11, 2016
  9. 11/13 apply: refactor `git apply` option parsingChristian Couder, Aug 11, 2016
  10. 08/13 usage: add set_warn_routine()Christian Couder, Aug 11, 2016
  11. 10/13 apply: change error_routine when silentChristian Couder, Aug 11, 2016
  12. 13/13 builtin/am: use apply API in run_apply()Christian Couder, Aug 11, 2016
  13. 12/13 apply: learn to use a different index fileChristian Couder, Aug 11, 2016
  14. Junio C HamanoAug 11, 2016
  15. Christian CouderAug 26, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.