git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 0/2] format-patch: Transition the default to --from to avoid spoofed mails

From
Josh Triplett <josh@joshtriplett.org>
Date
Jul 30, 2016, 19:11 UTC
Message-ID
<20160730191104.2ps5k7eji7aqgufg@x>
In-Reply-To
<20160730181246.4aifnvqfeenddzdl@x>

As discussed, this patch series allows transitioning the default behavior of format-patch to --from, to avoid spoofing mails when formatting commits not written by the user.

The first patch introduces the format.from option to set the default value of format-patch --from. This patch doesn't change the default behavior of format-patch, so it can go in without any transition.

The second patch changes the default to --from. If you'd like to delay this patch for a release and mention the planned change in the release notes, let me know and I'll provide text for the release notes; if you don't think this needs a transition period, you can go ahead and apply the second patch.

v2: Unify the various places setting from into a single helper function.
Josh Triplett (2):
  format-patch: Add a config option format.from to set the default for --from
  format-patch: Default to --from
 Documentation/config.txt               | 10 ++++-
 builtin/log.c                          | 47 +++++++++++++++----
 contrib/completion/git-completion.bash |  1 +-
 t/t4014-format-patch.sh                | 68 +++++++++++++++++++++++++--
 4 files changed, 114 insertions(+), 12 deletions(-)
-- 
git-series 0.8.7
Previous: Josh TriplettNext: Jeff King
Message 4 of 10 in “format-patch: Add a config option format.from to set the default for --from”
  1. 1/2 format-patch: Add a config option format.from to set the default for --fromJosh Triplett, Jul 30, 2016
  2. Jeff KingJul 30, 2016
  3. Josh TriplettJul 30, 2016
  4. 0/2 format-patch: Transition the default to --from to avoid spoofed mailsJosh Triplett, Jul 30, 2016
  5. Jeff KingAug 1, 2016
  6. Josh TriplettAug 1, 2016
  7. Jeff KingAug 1, 2016
  8. Junio C HamanoAug 1, 2016
  9. Josh TriplettAug 8, 2016
  10. 2/2 format-patch: Default to --fromJosh Triplett, Jul 30, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.