Re: [RFC] git-format-patch: default to --from to avoid spoofed mails?

From: Jeff King <peff@peff.net>
Date: Jul 30, 2016, 05:47 UTC
Message-ID: <20160730054742.iwmr4pavdy5z73rw@sigill.intra.peff.net>
In-Reply-To: <20160730045055.e3t6tpgi6zch4epo@x>

On Fri, Jul 29, 2016 at 09:50:55PM -0700, Josh Triplett wrote:

Show 11 quoted lines

> I would propose the following then:
> 
> - I'll write a patch adding a config option format.from, along with
>   documentation, without changing the default.
> - The release notes for the version of git introducing that config
>   option should mention, prominently, the plan to change the default in
>   a future version of git.
> - A subsequent release can change the default.  No major rush to do
>   this.
> 
> Does that sound reasonable?

That sounds fine to me.

I do have to admit that after reading through the "format.*" section of git-config(1), there is quite a bit that is configurable in it. So perhaps we do not need to be as careful about behavior changes as I thought.

So if you wanted to squish steps 2 and 3 together, that would also be OK by me.

-Peff