Re: Issue with global config defaults "user.useConfigOnly = true" + "pull.rebase = preserve" - "user.email"

From: Jeff King <peff@peff.net>
Date: Jul 29, 2016, 18:31 UTC
Message-ID: <20160729183143.GB9877@sigill.intra.peff.net>
In-Reply-To: <xmqqa8h0nw5a.fsf@gitster.mtv.corp.google.com>

On Fri, Jul 29, 2016 at 11:20:49AM -0700, Junio C Hamano wrote:

Show 8 quoted lines

> There is one that still wants to know who you are, I think.  The
> reflog entries record who moved the tip of the ref and when, and
> obviously a fast-forward is also recorded.
> 
> I _think_ our intention was to allow a bogus ident in reflog entries
> (even though we want to avoid a bogus ident in commits and tags), so
> perhaps additional code/logic for user.useConfigOnly may need to know
> about that (I didn't dig)?

I think we handle this case OK, or you would not even be able to "git fetch" into a repository.

It works because the check is predicated on the "strict" flag, and the reflog writer passes IDENT_NO_STRICT.

-Peff