git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/3] t7900-subtree.sh: fix quoting and broken && chains

From
David Aguilar <davvid@gmail.com>
Date
Jul 26, 2016, 04:14 UTC
Message-ID
<20160726041416.9438-1-davvid@gmail.com>

Allow whitespace in arguments to subtree_test_create_repo. Add missing && chains.

Signed-off-by: David Aguilar <davvid@gmail.com>
---
 contrib/subtree/t/t7900-subtree.sh | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/contrib/subtree/t/t7900-subtree.sh b/contrib/subtree/t/t7900-subtree.sh
index 3bf96a9..431a2fe 100755
--- a/contrib/subtree/t/t7900-subtree.sh
+++ b/contrib/subtree/t/t7900-subtree.sh
@@ -16,16 +16,16 @@ export TEST_DIRECTORY
 
 subtree_test_create_repo()
 {
-	test_create_repo "$1"
+	test_create_repo "$1" &&
 	(
-		cd $1
+		cd "$1" &&
 		git config log.date relative
 	)
 }
 
 create()
 {
-	echo "$1" >"$1"
+	echo "$1" >"$1" &&
 	git add "$1"
 }
 
@@ -73,10 +73,10 @@ join_commits()
 test_create_commit() (
 	repo=$1
 	commit=$2
-	cd "$repo"
-	mkdir -p $(dirname "$commit") \
+	cd "$repo" &&
+	mkdir -p "$(dirname "$commit")" \
 	|| error "Could not create directory for commit"
-	echo "$commit" >"$commit"
+	echo "$commit" >"$commit" &&
 	git add "$commit" || error "Could not add commit"
 	git commit -m "$commit" || error "Could not commit"
 )
-- 
2.9.2.466.g8c6d1f9.dirty
Next: David Aguilar
Message 1 of 7 in “t7900-subtree.sh: fix quoting and broken && chains”
  1. 1/3 t7900-subtree.sh: fix quoting and broken && chainsDavid Aguilar, Jul 26, 2016
  2. 2/3 subtree: fix "git subtree split --rejoin"David Aguilar, Jul 26, 2016
  3. 3/3 subtree: adjust style to match CodingGuidelinesDavid Aguilar, Jul 26, 2016
  4. Johannes SixtJul 26, 2016
  5. Junio C HamanoJul 26, 2016
  6. Eric SunshineJul 26, 2016
  7. Junio C HamanoJul 26, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.