Re: [PATCH] config.mak.uname: correct perl path on FreeBSD

From: Eric Wong <e@80x24.org>
Date: Jul 25, 2016, 20:33 UTC
Message-ID: <20160725203316.GA32053@starla>
In-Reply-To: <xmqqinvt610x.fsf@gitster.mtv.corp.google.com>

Junio C Hamano <gitster@pobox.com> wrote:

Show 8 quoted lines

> Duy Nguyen <pclouds@gmail.com> writes:
> 
> > On Mon, Jul 25, 2016 at 6:56 PM, Junio C Hamano <gitster@pobox.com> wrote:
> >> On Mon, Jul 25, 2016 at 9:21 AM, Nguyễn Thái Ngọc Duy <pclouds@gmail.com> wrote:
> >>> It looks the the symlink /usr/bin/perl (to /usr/local/bin/perl) has
> >>> been removed at least on FreeBSD 10.3. See [1] for more information.
> >>>
> >>> [1] https://svnweb.freebsd.org/ports/head/UPDATING?r1=386270&r2=386269&pathrev=386270&diff_format=c

Ah, I missed that. I guess that explains why nobody complained about the problem sooner.

Show 19 quoted lines

> >>> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
> >>> ---
> >>>  Tested with fbsd 10.3, kvm image. But I suppose it's the same as real
> >>>  fbsd.
> >>
> >> Thanks; and we know that older (but not too old that we no longer care about)
> >> FreeBSD all have /usr/local/bin/perl?
> >
> > I'm no fbsd expert but from the first sentence in [1] "Perl has been
> > removed from base more than ten years ago..." I would assume it meant
> > "... removed from base, _to_ ports system" which means /usr/local for
> > all package installation (for ten years for perl). So I think we are
> > good.
> 
> I guess we didn't follow through
> 
>     http://public-inbox.org/git/%3C20160720025630.GA71874%40plume%3E/
> 
> and allowed the thread to drift into a tangent?

+Cc Dscho

I've been meaning to followup on that, but had connectivity problems to my VM last week. I still prefer we use numeric comparisons for version numbers since numbers are... numeric. IOW, I prefer we go with my original patch.