git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: format-patch with pager.format-patch=true gets very confused

From
Josh Triplett <josh@joshtriplett.org>
Date
Jul 17, 2016, 19:20 UTC
Message-ID
<20160717192019.GA29262@x>
In-Reply-To
<alpine.DEB.2.20.1607171438030.28832@virtualbox>
On Sun, Jul 17, 2016 at 02:41:48PM +0200, Johannes Schindelin wrote:
Show 26 quoted lines
> Hi Josh,
> 
> On Sat, 16 Jul 2016, Josh Triplett wrote:
> 
> > git-config(1) documents the ability to enable or disable the pager (or
> > set a command-specific pager) for any command by setting
> > pager.<cmd>=true.  For most commands, this seems to work as expected.
> > However, setting pager.format-patch=true (or setting it to any specific
> > pager) breaks badly: the pager spawns, with no output in it, and the
> > pager doesn't respond to keystrokes (which makes it difficult to quit).
> > 
> > I think this may occur because format-patch's "reopen_stdout" interacts
> > badly with the pager.
> > 
> > I think it makes sense for "format-patch --stdout" to respect
> > pager.format-patch, but for format-patch *without* stdout to ignore
> > pager.* and *never* spawn a pager, given that its only output (the list
> > of patch files) goes to "realstdout".
> 
> As per http://article.gmane.org/gmane.comp.version-control.git/299451,
> the `js/log-to-diffopt-file` patch series will be merged to `master` soon.
> This patch series avoids the reopen() altogether and should fix the
> problem you experience.
> 
> Since it is already in `next`, it should be relatively easy for you to
> build and confirm. Would you kindly do that?
I can confirm that that fixes the problem.  Thanks!
- Josh Triplett
Previous: Johannes Schindelin
Message 3 of 3 in “format-patch with pager.format-patch=true gets very confused”
  1. Josh TriplettJul 17, 2016
  2. Johannes SchindelinJul 17, 2016
  3. Josh TriplettJul 17, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.