[PATCH 07/12] clone: use a real progress meter for connectivity check
- From
Jeff King <peff@peff.net>
- Date
- Jul 15, 2016, 10:33 UTC
- Message-ID
- <20160715103318.GG19271@sigill.intra.peff.net>
- In-Reply-To
- <20160715102506.GA23164@sigill.intra.peff.net>
Because the initial connectivity check for a cloned repository can be slow, 0781aa4 (clone: let the user know when check_everything_connected is run, 2013-05-03) added a "fake" progress meter; we simply say "Checking connectivity" when it starts, and "done" at the end, with nothing between.
Since check_connected() now knows how to do a real progress meter, we can drop our fake one and use that one instead.
Signed-off-by: Jeff King <peff@peff.net> --- Obviously not related to the receive-pack bits, but we get this for free because of the earlier refactoring.
builtin/clone.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/builtin/clone.c b/builtin/clone.c index 32fe606..f044a8c 100644 --- a/builtin/clone.c +++ b/builtin/clone.c @@ -627,13 +627,10 @@ static void update_remote_refs(const struct ref *refs, struct check_connected_options opt = CHECK_CONNECTED_INIT; opt.transport = transport; + opt.progress = transport->progress; - if (transport->progress) - fprintf(stderr, _("Checking connectivity... ")); if (check_connected(iterate_ref_map, &rm, &opt)) die(_("remote did not send all necessary objects")); - if (transport->progress) - fprintf(stderr, _("done.\n")); } if (refs) {
-- 2.9.1.434.g748be50