Re: [ANNOUNCE] Git v2.9.1

From: Jeff King <peff@peff.net>
Date: Jul 12, 2016, 01:15 UTC
Message-ID: <20160712011533.GA28601@sigill.intra.peff.net>
In-Reply-To: <20160712005611.GA16810@dcvr.yhbt.net>

On Tue, Jul 12, 2016 at 12:56:11AM +0000, Eric Wong wrote:

Show 8 quoted lines

> Jeff King <peff@peff.net> wrote:
> > Otherwise, we'll have to skip the test, perhaps with something like the
> > patch below. I suspect the problem is actually the size of "unsigned
> > long", not time_t, as we use that internally for a bunch of time
> > computation.
> 
> We should probably be using int64_t for time calculations;
> "unsigned long" is 32-bits on 32-bit x86 systems.

I'd agree (or probably just "time_t", which I would hope would be a future-proof length even on 32-bit systems).

It's just that it's baked into a lot of different function interfaces and structs in the code, and nobody has taken the time to review and change it all (since it doesn't actually affect current timestamps and won't for a while).

-Peff