git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/3] http-walker: remove unused parameter from fetch_object

From
EWEric Wong <e@80x24.org>
Date
Jul 11, 2016, 20:51 UTC
Message-ID
<20160711205131.1291-2-e@80x24.org>
In-Reply-To
<20160711205131.1291-1-e@80x24.org>

This parameter has not been used since commit 1d389ab65dc6 ("Add support for parallel HTTP transfers") back in 2005

Signed-off-by: Eric Wong <e@80x24.org>
---
 http-walker.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/http-walker.c b/http-walker.c
index 2c721f0..9f28523 100644
--- a/http-walker.c
+++ b/http-walker.c
@@ -447,7 +447,7 @@ static void abort_object_request(struct object_request *obj_req)
 	release_object_request(obj_req);
 }
 
-static int fetch_object(struct walker *walker, struct alt_base *repo, unsigned char *sha1)
+static int fetch_object(struct walker *walker, unsigned char *sha1)
 {
 	char *hex = sha1_to_hex(sha1);
 	int ret = 0;
@@ -518,7 +518,7 @@ static int fetch(struct walker *walker, unsigned char *sha1)
 	struct walker_data *data = walker->data;
 	struct alt_base *altbase = data->alt;
 
-	if (!fetch_object(walker, altbase, sha1))
+	if (!fetch_object(walker, sha1))
 		return 0;
 	while (altbase) {
 		if (!http_fetch_pack(walker, altbase, sha1))
-- 
EW
Previous: Eric WongNext: Eric Wong
Message 2 of 7 in “[RFC 0/3] dumb HTTP transport speedups”
  1. Eric WongJul 11, 2016
  2. 1/3 http-walker: remove unused parameter from fetch_objectEric Wong, Jul 11, 2016
  3. 2/3 http: avoid disconnecting on 404s for loose objectsEric Wong, Jul 11, 2016
  4. 3/3 http-walker: reduce O(n) ops with doubly-linked listEric Wong, Jul 11, 2016
  5. 4/3 http-walker: use hashmap to reduce list scanEric Wong, Jul 11, 2016
  6. Jakub NarębskiJul 24, 2016
  7. Eric WongJul 24, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.