Re: Commits are no longer gpg-signed in 2.9.0 when "commit.gpgsign" is enabled

From: Santiago Torres <santiago@nyu.edu>
Date: Jul 11, 2016, 14:44 UTC
Message-ID: <20160711144420.nsibnudjxvgdz7cl@LykOS.localdomain>
In-Reply-To: <57838306.5090505@web.de>

Hi Nils,

I just checked and I have commits made in 2.9 with this option set and I don't seem to have your issue. Here's what I did:

    santiago at ~/test-signing ✔ git init
    Initialized empty Git repository in /home/santiago/test-signing/.git/
    santiago at ~/test-signing ✔ hub create
    Updating origin
    Enter passphrase for key '/home/santiago/.ssh/id_rsa': 
    created repository: SantiagoTorres/test-signing
    santiago at ~/test-signing ✔ touch testfile
    santiago at ~/test-signing ✔ git add testfile 
    santiago at ~/test-signing ✔ git commit
    i[master (root-commit) 6de1ad2] TEST: tests git autocommit setting
     1 file changed, 0 insertions(+), 0 deletions(-)
     create mode 100644 testfile
    santiago at ~/test-signing ✔ git log --show-signature
    commit 6de1ad20237f042433f8b94a3bf8c7cc41711d90 (HEAD -> refs/heads/master)
    gpg: Signature made Mon 11 Jul 2016 10:40:41 AM EDT using RSA key ID 468F122CE8162295
    gpg: Good signature from "Santiago Torres <torresariass@gmail.com>" [ultimate]
    gpg:                 aka "Santiago Torres-Arias <santiago@nyu.edu>" [ultimate]
    Author: Santiago Torres <torresariass@gmail.com>
    Date:   Mon Jul 11 10:40:32 2016 -0400

        TEST: tests git autocommit setting
    santiago at ~/test-signing ✔ git push origin master
    Enter passphrase for key '/home/santiago/.ssh/id_rsa': 
    Counting objects: 3, done.
    Writing objects: 100% (3/3), 879 bytes | 0 bytes/s, done.
    Total 3 (delta 0), reused 0 (delta 0)
    To git@github.com:SantiagoTorres/test-signing.git
     * [new branch]      master -> master
    santiago at ~/test-signing ✔ git --version
    git version 2.9.0
    santiago at ~/test-signing ✔

You can check the github repository

Do you have a mwe/.gitconfig so I can take a look at it?

I wonder if this issue is similar to what happened in mutt, where gpg doesn't show the password prompt using gpg-agent and it silently failed.

Thanks, -Santiago.

On Mon, Jul 11, 2016 at 01:29:10PM +0200, Nils Fenner wrote:

Show 25 quoted lines

> Hey Git community,
> 
> since Version 2.9.0, the configuration option "commit.gpgsign" doesn't work
> as users would expect. By committing via 'git gui' (or usual 'git commit'
> without further option), commits are not being auto-signed any longer, when
> "commit.gpgSign" configuration option is set. I also couldn't find a flag to
> "workaround" that situation in the GUI. To my understanding, I now have to
> pass the '-S' option to 'git commit' every time and GUI becomes "impractical
> to use". Surprisingly, nobody seems having noticed this behavioural change
> since the release of 2.9.
> 
> FYI: In the release log, there's a note stating, that this has been altered
> in the context of 'git commit-tree'. Maybe this interferes with "normal"
> behaviour.
> 
> Would be happy hearing from you soon. Thanks!
> 
> Cheers,
> Nils
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html