[PATCH] config.mak.uname: define NEEDS_LIBRT under Linux, for now
- From
- Eric Wong <e@80x24.org>
- Date
- Jul 10, 2016, 22:16 UTC
- Message-ID
- <20160710221644.GA4927@whir>
- In-Reply-To
- <xmqqwpkxnoae.fsf@gitster.mtv.corp.google.com>
Junio C Hamano <gitster@pobox.com> wrote:
Show 10 quoted lines
> Ronald Wampler <rdwampler@gmail.com> writes: > > > I am not sure if this the correction solution. Another option I > > considered was to wrap the EXTLIBS += -lrt is an ifndef NO_RT and only > > defining NO_RT for Mac OS X in config.mak.uname. > > That alternative would make the resulting code noisier/uglier with > nested ifdef, I would imagine, but it would be of less impact to the > existing users. But my gut feeling is that the patch you sent is > probably a better solution for the longer term.
That change broke my Debian wheezy LTS system, which isn't too out-of-date. I think having excessive linkage on newer systems is preferable to breaking the out-of-the-box experience.
I don't know about other platforms, but I think the following will help users on older GNU/Linux systems for the next few years:
-------8<------ Subject: [PATCH] config.mak.uname: define NEEDS_LIBRT under Linux, for now
My Debian wheezy LTS system is still on glibc 2.13; and LTS distros may use older glibc, still, so lets not unnecessarily break things out-of-the-box.
We seem to assume Linux is using glibc in our Makefiles anyways, so I don't think this will introduce new breakage for users of alternative libc implementations.
Signed-off-by: Eric Wong <e@80x24.org> --- config.mak.uname | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/config.mak.uname b/config.mak.uname index a88f139..22958a8 100644 --- a/config.mak.uname +++ b/config.mak.uname @@ -36,6 +36,8 @@ ifeq ($(uname_S),Linux) HAVE_DEV_TTY = YesPlease HAVE_CLOCK_GETTIME = YesPlease HAVE_CLOCK_MONOTONIC = YesPlease + # -lrt is needed for clock_gettime on glibc <= 2.16 + NEEDS_LIBRT = YesPlease HAVE_GETDELIM = YesPlease SANE_TEXT_GREP=-a endif
-- EW