[PATCH v2] rebase -i: restore autostash on abort
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Jun 29, 2016, 06:21 UTC
- Message-ID
- <20160629062127.8946-1-ps@pks.im>
- In-Reply-To
- <20160628175704.26095-1-ps@pks.im>
When we abort an interactive rebase we do so by calling `die_abort`, which cleans up after us by removing the rebase state directory. If the user has requested to use the autostash feature, though, the state directory may also contain a reference to the autostash, which will now be deleted.
Fix the issue by trying to re-apply the autostash in `die_abort`. This will also handle the case where the autostash does not apply cleanly anymore by recording it in a user-visible stash.
Reported-by: Daniel Hahler <git@thequod.de> Signed-off-by: Patrick Steinhardt <ps@pks.im> ---
The original bug-report can be found at [1], the previous version of this patch at [2].
I've included a second test which now also tests how we fare when we actually fail to restore the autostash after the editor has been aborted.
Another minor change is fixing of a typo inherited from the previous test "abort rebase -i with --autostash" (commited -> committed). I don't think there's any benefit in fixing the typo in the existing test so I'll just keep it there.
[1]: http://article.gmane.org/gmane.comp.version-control.git/297404 [2]: http://article.gmane.org/gmane.comp.version-control.git/298481
git-rebase--interactive.sh | 1 + t/t3420-rebase-autostash.sh | 31 +++++++++++++++++++++++++++++++ 2 files changed, 32 insertions(+)
diff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh index 05f22e4..4f499d2 100644 --- a/git-rebase--interactive.sh +++ b/git-rebase--interactive.sh @@ -212,6 +212,7 @@ exit_with_patch () { } die_abort () { + apply_autostash rm -rf "$state_dir" die "$1" } diff --git a/t/t3420-rebase-autostash.sh b/t/t3420-rebase-autostash.sh index 944154b..532ff5c 100755 --- a/t/t3420-rebase-autostash.sh +++ b/t/t3420-rebase-autostash.sh @@ -192,4 +192,35 @@ test_expect_success 'abort rebase -i with --autostash' ' test_cmp expected file0 ' +test_expect_success 'restore autostash on editor failure' ' + test_when_finished "git reset --hard" && + echo uncommitted-content >file0 && + ( + test_set_editor "false" && + test_must_fail git rebase -i --autostash HEAD^ + ) && + echo uncommitted-content >expected && + test_cmp expected file0 +' + +test_expect_success 'autostash is saved on editor failure with conflict' ' + test_when_finished "git reset --hard" && + echo uncommitted-content >file0 && + ( + write_script abort-editor.sh <<-\EOF && + echo conflicting-content >file0 + exit 1 + EOF + test_set_editor "$(pwd)/abort-editor.sh" && + test_must_fail git rebase -i --autostash HEAD^ && + rm -f abort-editor.sh + ) && + echo conflicting-content >expected && + test_cmp expected file0 && + git checkout file0 && + git stash pop && + echo uncommitted-content >expected && + test_cmp expected file0 +' + test_done
-- 2.9.0