git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC] gc: correct gc.autoPackLimit documentation

From
EWEric Wong <e@80x24.org>
Date
Jun 25, 2016, 02:53 UTC
Message-ID
<20160625025300.GA29053@dcvr.yhbt.net>
In-Reply-To
<20160625020620.GA31290@sigill.intra.peff.net>
Jeff King <peff@peff.net> wrote:
Show 26 quoted lines
> On Sat, Jun 25, 2016 at 01:14:50AM +0000, Eric Wong wrote:
> 
> > I'm not sure if this is the best approach, or if changing
> > too_many_packs can be done without causing problems for
> > hosts of big repos.
> > 
> > -------8<-----
> > Subject: [PATCH] gc: correct gc.autoPackLimit documentation
> > 
> > I want to ensure there is only one pack in my repo to take
> > advantage of pack bitmaps.  Based on my reading of the
> > documentation, I configured gc.autoPackLimit=1 which led to
> > "gc --auto" constantly trying to repack on every invocation.
> 
> I'm not sure if you might be misinterpreting earlier advice on bitmaps
> here. At the time of packing, bitmaps need for all of the objects to go
> to a single pack (they cannot handle a case where one object in the pack
> can reach another object that is not in the pack). But that is easily
> done with "git repack -adb".
> 
> After that packing, you can add new packs that do not have bitmaps, and
> the bitmaps will gracefully degrade. E.g., imagine master was at tip X
> when you repacked with bitmaps, and now somebody has pushed to make it
> tip Y.  Somebody then clones, asking for Y. The bitmap code will start
> at Y and walk backwards. When it hits X, it stops walking as it can fill
> in the rest of the reachability from there.

Ah, thanks, makes sense. I was misinterpreting earlier advice on bitmaps.

> That's neither here nor there for the off-by-one in gc or its
> documentation, of course, but just FYI.

I'm now inclined to fix the problem in gc and leave the documentation as-is (unless it cause other problems...)

Previous: Jeff KingNext: Junio C Hamano
Message 3 of 6 in “[RFC] gc: correct gc.autoPackLimit documentation”
  1. Eric WongJun 25, 2016
  2. Jeff KingJun 25, 2016
  3. Eric WongJun 25, 2016
  4. Junio C HamanoJun 25, 2016
  5. gc: fix off-by-one error with gc.autoPackLimitEric Wong, Jun 25, 2016
  6. Jeff KingJun 27, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.