Re: Use docker for _some_ testing?

From: Jeff King <peff@peff.net>
Date: Jun 22, 2016, 19:59 UTC
Message-ID: <20160622195932.GC1697@sigill.intra.peff.net>
In-Reply-To: <20160622190154.GA17442@duynguyen>

On Wed, Jun 22, 2016 at 09:01:55PM +0200, Duy Nguyen wrote:

Show 7 quoted lines

> Which makes me think, could we use something like this to make sure
> people (on Linux) can test more obscure cases? Sometimes there are
> featues that require some dependencies that are not always present on
> the developer's machine (http server is a big one, locales come close
> second, then there will be lmdb and watchman in future...). With this,
> said developer can do a final test run in docker covering as much as
> possible.

Neat idea. This should also cover some other distro-specific issues like "what's your /bin/sh look like", etc. It's a lighter-weight alternative to testing alternate distros in a VM.

But I think most of the interesting cases are more exotic than distro-to-distro. Things like HFS+ normalization, or weird shell toolchains on proprietary Unixes (but maybe there are docker images for those systems?).

So I dunno if it would prove that useful for day to day use or not.

> +ROOT="$(realpath $(git rev-parse --show-cdup))"

I tried running this as contrib/docker/run.sh, which complained here, because --show-cdup is empty.

> +test "$(docker images --format='{{.Repository}}' $IMAGE)" = $IMAGE || \
> +	build_$DISTRO

My docker complained that it doesn't know --format. I guess I might just have an old one (it's whatever is in Debian unstable, which is 1.8.3).

Not things you need to fix, but just comments for anybody else fiddling with it.

-Peff