Re: [PATCH] shallow clone to not imply shallow submodules

From: Jeff King <peff@peff.net>
Date: Jun 20, 2016, 17:13 UTC
Message-ID: <20160620171312.GA1880@sigill.intra.peff.net>
In-Reply-To: <1466441998-18896-1-git-send-email-sbeller@google.com>

On Mon, Jun 20, 2016 at 09:59:58AM -0700, Stefan Beller wrote:

Show 8 quoted lines

> Signed-off-by: Stefan Beller <sbeller@google.com>
> ---
> 
> Hi Junio, Peff,
> 
> I thought about this patch squashed into  
> "clone: do not let --depth imply --shallow-submodules" will actually test
> for the regression.

Yep, it looks good to me.

Show 14 quoted lines

> +test_expect_success 'shallow clone does not imply shallow submodule' '
> +	test_when_finished "rm -rf super_clone" &&
> +	git clone --recurse-submodules --depth 2 "file://$pwd/." super_clone &&
> +	(
> +		cd super_clone &&
> +		git log --oneline >lines &&
> +		test_line_count = 2 lines
> +	) &&
> +	(
> +		cd super_clone/sub &&
> +		git log --oneline >lines &&
> +		test_line_count = 3 lines
> +	)
> +'

This follows the style of the other tests, so it's the right thing here. But as a style suggestion, I think:

  git -C super_clone/sub log --oneline >lines &&
  test_line_count = 3 lines

is nicer than the subshell. It's more succinct, and it saves a process.

-Peff