Re: [PATCH 4/3] use string_list initializer consistently

From: Jeff King <peff@peff.net>
Date: Jun 13, 2016, 17:32 UTC
Message-ID: <20160613173246.GA8245@sigill.intra.peff.net>
In-Reply-To: <CACsJy8CoOJKLUQXPKx_KvHvwbUdOfyBKu_-v5F2U7ccrmCcewA@mail.gmail.com>

On Mon, Jun 13, 2016 at 06:31:29PM +0700, Duy Nguyen wrote:

Show 10 quoted lines

> > This is a fairly mechanical conversion; I assumed each site
> > was correct as-is, and just switched them all to NODUP.
> 
> Looking good. If we still want to reduce noise level down (by a tiny
> bit), we could remove _INIT because I think it's obvious from
> 
> struct string_list var = STRING_LIST_NODUP;
> 
> that's it's initialization (I wish we could write "auto var =
> STRING_LIST_NODUP;")

Yeah, I've always felt it's a bit long. The "INIT" does match other similar macros, but I agree it could probably go. Definitely something for a separate patch, though.

-Peff