Re: [PATCH] write_or_die: remove the unused write_or_whine() function
- From
Jeff King <peff@peff.net>
- Date
- Jun 10, 2016, 00:01 UTC
- Message-ID
- <20160610000107.GA25874@sigill.intra.peff.net>
- In-Reply-To
- <5759F326.9080101@ramsayjones.plus.com>
On Thu, Jun 09, 2016 at 11:52:22PM +0100, Ramsay Jones wrote:
Show 13 quoted lines
>
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>
> Hi Junio,
>
> Commit f0bca72d ("send-pack: use buffered I/O to talk to pack-objects",
> 08-06-2016) removed the last use of write_or_whine(). I had intended to
> include this 'commit citation' in the commit message, but until it reaches
> the next branch, I don't know how stable that information will be.
>
> Anyway, on reflection, the subject line says everything that needs to be
> said. However, you need to know which commit this one depends on. ;-)IMHO, it's a good idea for removal patches to reflect on why the thing is appropriate to remove. Obviously there are no callers, but do we expect any to come back? I think probably not, because this function is doing very little that a regular if() does not besides obfuscating the error message (and if we ever did want something like it, we would probably prefer the function to come back with more "normal" return value semantics).
-Peff