Re: [PATCH 1/2] Do not output whitespace on blank lines

From: Thomas Gummerer <t.gummerer@gmail.com>
Date: May 29, 2016, 17:06 UTC
Message-ID: <20160529170637.GC2286@hank>
In-Reply-To: <01020154fd28aa12-f536bf3e-58df-4d1f-b903-929b429954d3-000000@eu-west-1.amazonses.com>

On 05/29, Dave Nicolson wrote:

> ---

The commit message should describe why you think this is a good change. Without the commit message I don't see how this is a improvement. It is also missing your Sign-off (see Documentation/SubmittingPatches section 5).

The test changes you sent in Patch 2/2 should be in this commit, otherwise the git bisect is broken when it hits this patch, which is something we want to avoid.

Show 23 quoted lines

>  diff.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/diff.c b/diff.c
> index d3734d3..459b36a 100644
> --- a/diff.c
> +++ b/diff.c
> @@ -471,7 +471,7 @@ static void emit_line_0(struct diff_options *o, const char *set, const char *res
>  		has_trailing_carriage_return = (len > 0 && line[len-1] == '\r');
>  		if (has_trailing_carriage_return)
>  			len--;
> -		nofirst = 0;
> +		nofirst = len == 0 && (char)first == ' ' ? 1 : 0;
>  	}
>  
>  	if (len || !nofirst) {
> 
> --
> https://github.com/git/git/pull/245
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Thomas