Re: [PATCH v8 0/9] connect: various cleanups
On Fri, May 27, 2016 at 04:24:20PM +0200, Torsten Bögershausen wrote:
Show 23 quoted lines
> On 27.05.16 04:27, Mike Hommey wrote:
> > Changes from v7:
> > - Fixed comments.
> >
> > Mike Hommey (9):
> > connect: document why we sometimes call get_port after
> > get_host_and_port
> > connect: call get_host_and_port() earlier
> > connect: re-derive a host:port string from the separate host and port
> > variables
> > connect: make parse_connect_url() return separated host and port
> > connect: group CONNECT_DIAG_URL handling code
> > connect: make parse_connect_url() return the user part of the url as a
> > separate value
> > connect: change the --diag-url output to separate user and host
> > connect: actively reject git:// urls with a user part
> > connect: move ssh command line preparation to a separate function
> >
> > connect.c | 235 +++++++++++++++++++++++++++++---------------------
> > t/t5500-fetch-pack.sh | 42 ++++++---
> > 2 files changed, 170 insertions(+), 107 deletions(-)
> >
> Is the whole series somewhere on a public repo ?
> No major remarks so far, if possible, I would like
> to have a look at the resulting connect.c
https://github.com/glandium/git/blob/connect/connect.c
Mike