git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v8 0/9] connect: various cleanups

From
Mike Hommey <mh@glandium.org>
Date
May 27, 2016, 21:59 UTC
Message-ID
<20160527215943.GA21018@glandium.org>
In-Reply-To
<a6f4bf06-a52b-dcdf-9407-0c03b8b1dfe1@web.de>
On Fri, May 27, 2016 at 04:24:20PM +0200, Torsten Bögershausen wrote:
Show 23 quoted lines
> On 27.05.16 04:27, Mike Hommey wrote:
> > Changes from v7:
> > - Fixed comments.
> > 
> > Mike Hommey (9):
> >   connect: document why we sometimes call get_port after
> >     get_host_and_port
> >   connect: call get_host_and_port() earlier
> >   connect: re-derive a host:port string from the separate host and port
> >     variables
> >   connect: make parse_connect_url() return separated host and port
> >   connect: group CONNECT_DIAG_URL handling code
> >   connect: make parse_connect_url() return the user part of the url as a
> >     separate value
> >   connect: change the --diag-url output to separate user and host
> >   connect: actively reject git:// urls with a user part
> >   connect: move ssh command line preparation to a separate function
> > 
> >  connect.c             | 235 +++++++++++++++++++++++++++++---------------------
> >  t/t5500-fetch-pack.sh |  42 ++++++---
> >  2 files changed, 170 insertions(+), 107 deletions(-)
> > 
> Is the whole series somewhere on a public repo ?
Is it now :)
> No major remarks so far, if possible, I would like
> to have a look at the resulting connect.c
https://github.com/glandium/git/blob/connect/connect.c
Mike
Previous: Torsten BögershausenNext: Torsten Bögershausen
Message 12 of 16 in “connect: various cleanups”
  1. 0/9 connect: various cleanupsMike Hommey, May 27, 2016
  2. 1/9 connect: document why we sometimes call get_port after get_host_and_portMike Hommey, May 27, 2016
  3. 2/9 connect: call get_host_and_port() earlierMike Hommey, May 27, 2016
  4. 3/9 connect: re-derive a host:port string from the separate host and port variablesMike Hommey, May 27, 2016
  5. 4/9 connect: make parse_connect_url() return separated host and portMike Hommey, May 27, 2016
  6. 5/9 connect: group CONNECT_DIAG_URL handling codeMike Hommey, May 27, 2016
  7. 6/9 connect: make parse_connect_url() return the user part of the url as a separate valueMike Hommey, May 27, 2016
  8. 7/9 connect: change the --diag-url output to separate user and hostMike Hommey, May 27, 2016
  9. 8/9 connect: actively reject git:// urls with a user partMike Hommey, May 27, 2016
  10. 9/9 connect: move ssh command line preparation to a separate functionMike Hommey, May 27, 2016
  11. Torsten BögershausenMay 27, 2016
  12. Mike HommeyMay 27, 2016
  13. Torsten BögershausenMay 28, 2016
  14. Mike HommeyMay 28, 2016
  15. Torsten BögershausenMay 28, 2016
  16. Mike HommeyMay 28, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.