Re: t7610-mergetool.sh test failure

From: Jeff King <peff@peff.net>
Date: May 27, 2016, 05:00 UTC
Message-ID: <20160527050054.GA25774@sigill.intra.peff.net>
In-Reply-To: <20160527044027.GA26143@gmail.com>

On Thu, May 26, 2016 at 09:40:27PM -0700, David Aguilar wrote:

Show 11 quoted lines

> > BTW, one thing I happened to note while looking at this: running the
> > test script will write into /tmp (or wherever your $TMPDIR points).
> > Probably not a big deal, but I wonder if we should be setting $TMPDIR in
> > our test harness.
> 
> We already set $HOME and various other variables to carefully
> tune the testsuite's behavior, so this sounds like a good idea
> IMO.
> 
> Would there be any downsides to setting $TMPDIR equal to the
> trash directory?

The only one I can think of is that if something leaves cruft in $TMPDIR, it could affect later tests that want to `git add` indiscriminately. It seems unlikely.

OTOH, I do not think putting things in /tmp is hurting anything. I was mostly just surprised by it.

-Peff