git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4 2/2] rev-parse: fix some options when executed from subpath of main tree

From
Mike Hommey <mh@glandium.org>
Date
May 26, 2016, 13:26 UTC
Message-ID
<20160526132611.GA2736@glandium.org>
In-Reply-To
<1464261556-89722-3-git-send-email-rappazzo@gmail.com>
On Thu, May 26, 2016 at 07:19:16AM -0400, Michael Rappazzo wrote:
Show 9 quoted lines
> Executing `git-rev-parse` with `--git-common-dir`, `--git-path <path>`,
> or `--shared-index-path` from the root of the main worktree results in
> a relative path to the git dir.
> 
> When executed from a subdirectory of the main tree, it can incorrectly
> return a path which starts 'sub/path/.git'.  Change this to return the
> proper relative path to the git directory.
> 
> Related tests marked to expect failure are updated to expect success

As mentioned previously (but late in the thread), I don't get why this one case of --git-common-dir should not return the same thing as --git-dir, which is an absolute directory. Especially when there is other flag telling you whether you are in the main or another worktree, so comparing the output for --git-dir and --git-common-dir is the easiest way to do so, but then you have to normalize them on their own because git returns different values pointing to the same directory.

Mike
Previous: Michael RappazzoNext: Junio C Hamano
Message 4 of 5 in “rev-parse: fix some options when executed from subpath of main tree”
  1. 0/2 rev-parse: fix some options when executed from subpath of main treeMichael Rappazzo, May 26, 2016
  2. 1/2 rev-parse tests: add tests executed from a subdirectoryMichael Rappazzo, May 26, 2016
  3. 2/2 rev-parse: fix some options when executed from subpath of main treeMichael Rappazzo, May 26, 2016
  4. Mike HommeyMay 26, 2016
  5. Junio C HamanoMay 27, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.