Re: [PATCH] daemon: enable SO_KEEPALIVE for all sockets
- From
- Eric Wong <e@80x24.org>
- Date
- May 25, 2016, 23:11 UTC
- Message-ID
- <20160525231114.GA20691@dcvr.yhbt.net>
- In-Reply-To
- <xmqq37p5zrjk.fsf@gitster.mtv.corp.google.com>
Junio C Hamano <gitster@pobox.com> wrote:
> This makes sense as a follow-up to e47a8583 (enable SO_KEEPALIVE for > connected TCP sockets, 2011-12-06), I think.
Yes, a15d069a19867 for http, too; hat trick :>
Anyways, it might've helped Savannah when they had networking problems:
http://mid.gmane.org/20160524214102858920068@bob.proulx.com
They might be running an old version that didn't send keepalive heartbeats during packing, too. But SO_KEEPALIVE will still help during init when --init-timeout is not set.
Perhaps it also makes sense to squash the following xinetd setting into giteveryday.txt, too; since some users could be running out-of-date git but reading new documentation on the web:
--- a/Documentation/giteveryday.txt +++ b/Documentation/giteveryday.txt @@ -390,6 +390,7 @@ service git server = /usr/bin/git-daemon server_args = --inetd --export-all --base-path=/pub/scm log_on_failure += USERID + flags = KEEPALIVE } ------------ +